From 7b1ae3bdc6512c7d0a26c6edd94b29c765db121a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mario=20H=C3=BCttel?= Date: Mon, 2 Nov 2020 18:20:17 +0100 Subject: [PATCH] Improve code in calibration module --- stm-firmware/calibration.c | 53 +++++++++++++++++++------------------- 1 file changed, 27 insertions(+), 26 deletions(-) diff --git a/stm-firmware/calibration.c b/stm-firmware/calibration.c index 1985cd7..81dd815 100644 --- a/stm-firmware/calibration.c +++ b/stm-firmware/calibration.c @@ -92,7 +92,7 @@ static float calculate_mean(float *values, uint32_t count) } while (--loop_cnt > 0); } - return sum/(float)count; + return sum / (float)count; } static float calculate_standard_deviation(float *values, uint32_t count, float mean) @@ -103,35 +103,36 @@ static float calculate_standard_deviation(float *values, uint32_t count, float m float res; switch (remainder) { - case 0: do { sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ - case 7: sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ - case 6: sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ - case 5: sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ - case 4: sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ - case 3: sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ - case 2: sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ - case 1: sum += (*values - mean) * (*values - mean); - values++; - /* FALLTHRU */ + case 0: do { + sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ + case 7: sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ + case 6: sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ + case 5: sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ + case 4: sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ + case 3: sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ + case 2: sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ + case 1: sum += (*values - mean) * (*values - mean); + values++; + /* FALLTHRU */ } while (--loop_cnt > 0); } sum /= (float)count; - /* Compute the square roor using the FPU. + /* Compute the square root using the FPU. * The constraint 't' tells GCC to use a floating point register */ __asm__ __volatile__("vsqrt.f32 %0, %1" : "=t"(res) : "t"(sum));