Fix #35: List with updae filename was freed before it was used. This is now fixed and working
This commit is contained in:
		@@ -673,10 +673,10 @@ static void gui_update_firmware(struct lcd_menu *menu, enum menu_entry_func_entr
 | 
				
			|||||||
			if (button == BUTTON_SHORT_RELEASED) {
 | 
								if (button == BUTTON_SHORT_RELEASED) {
 | 
				
			||||||
				fname = sl_list_nth(file_list, currently_selected_file)->data;
 | 
									fname = sl_list_nth(file_list, currently_selected_file)->data;
 | 
				
			||||||
				menu_display_clear(menu);
 | 
									menu_display_clear(menu);
 | 
				
			||||||
				sl_list_free_full(file_list, delete_file_list_entry);
 | 
					 | 
				
			||||||
				file_list = NULL;
 | 
									file_list = NULL;
 | 
				
			||||||
 | 
					 | 
				
			||||||
				updater_update_from_file(fname);
 | 
									updater_update_from_file(fname);
 | 
				
			||||||
 | 
									/* This code is here for completeness. It will never be reached! */
 | 
				
			||||||
 | 
									sl_list_free_full(file_list, delete_file_list_entry);
 | 
				
			||||||
			} else if (button == BUTTON_LONG) {
 | 
								} else if (button == BUTTON_LONG) {
 | 
				
			||||||
				sl_list_free_full(file_list, delete_file_list_entry);
 | 
									sl_list_free_full(file_list, delete_file_list_entry);
 | 
				
			||||||
				file_list = NULL;
 | 
									file_list = NULL;
 | 
				
			||||||
 
 | 
				
			|||||||
		Reference in New Issue
	
	Block a user