mhu/shimatta-kenkyusho
2
0
Fork 0
Code Issues 15 Pull Requests 2 Releases Wiki Activity

added CSV upload to enable fast creation of similar components #14

Merged
mhu merged 3 commits from feature/csv-import into develop 2024-11-17 21:55:44 +01:00
Conversation 0 Commits 3 Files Changed 11 +232 -8
sst commented 2024-11-17 19:54:38 +01:00
Collaborator
Copy Link
No description provided.
sst added 1 commit 2024-11-17 19:54:39 +01:00
mhu reviewed 2024-11-17 20:17:12 +01:00
examples/import_csv/readme.md Outdated
@ -0,0 +11,4 @@
storage uuid and/or the path to the storage (as printed in the breadcrumbs) or
a combination of a storage uuid and the path from this storage.
See example for details.
mhu commented 2024-11-17 20:14:32 +01:00
Owner
Copy Link

Can we add this help text as tooltip on the actual website? or maybe add a download link for the CSV file template so it can be filled out more easily.

Can we add this help text as tooltip on the actual website? or maybe add a download link for the CSV file template so it can be filled out more easily.
sst commented 2024-11-17 20:22:34 +01:00
Author
Collaborator
Copy Link

good point - will add it :)

good point - will add it :)
shimatta_kenkyusho/parts/views.py
@ -237,0 +242,4 @@
try:
import_components_from_csv(cform.files['csv_file'].file)
except Exception as ex:
cform.add_error('csv_file', str(ex))
mhu commented 2024-11-17 20:15:30 +01:00
Owner
Copy Link

Okay. The error handling is indeed a little bit basic 😄 But I guess it's okay for now.

Okay. The error handling is indeed a little bit basic 😄 But I guess it's okay for now.
shimatta_kenkyusho/templates/parts/stocks-detail.html
@ -38,3 +38,3 @@
<li class="list-group-item list-group-item-action justify-content-between align-items-center d-flex">
<div>
<h5>{{storage.name}}</h5>
<h5>{{storage.name}}{% if storage.verbose_name %}<small> ({{storage.verbose_name}})</small>{% endif %}</h5>
mhu commented 2024-11-17 20:17:05 +01:00
Owner
Copy Link

Sneaky 😛

Sneaky 😛
mhu marked this conversation as resolved
mhu changed title from added CSV upload to enable fast creation of similar components to WIP: added CSV upload to enable fast creation of similar components 2024-11-17 20:31:08 +01:00
mhu requested review from mhu 2024-11-17 20:31:21 +01:00
sst added 1 commit 2024-11-17 21:44:35 +01:00
sst changed title from WIP: added CSV upload to enable fast creation of similar components to added CSV upload to enable fast creation of similar components 2024-11-17 21:44:51 +01:00
sst added 1 commit 2024-11-17 21:44:54 +01:00
mhu approved these changes 2024-11-17 21:55:39 +01:00
mhu merged commit f1e366c7af into develop 2024-11-17 21:55:44 +01:00
Sign in to join this conversation.
Reviewers
No reviewers
mhu
Labels
Clear labels   
Compat/Breaking

Breaking change that won't be backward compatible

  
Kind/Bug

Something is not working

  
Kind/Documentation

Documentation changes

  
Kind/Enhancement

Improve existing functionality

  
Kind/Feature

New functionality

  
Kind/Security

This is security issue

  
Kind/Testing

Issue or pull request related to testing

  
Priority
Critical
The priority is critical

  
Priority
High
The priority is high

  
Priority
Low
The priority is low

  
Priority
Medium
The priority is medium

  
Reviewed
Confirmed
Issue has been confirmed

  
Reviewed
Duplicate
This issue or pull request already exists

  
Reviewed
Invalid
Invalid issue

  
Reviewed
Won't Fix
This issue won't be fixed

  
Status
Abandoned
Somebody has started to work on this but abandoned work

  
Status
Blocked
Something is blocking this issue or pull request

  
Status
Need More Info
Feedback is required to reproduce issue or to continue work

No Label
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: mhu/shimatta-kenkyusho#14
No description provided.
Delete Branch "feature/csv-import"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?