Stefan Strobel sst
sst commented on pull request mhu/shimatta-kenkyusho#32 2025-01-05 16:32:44 +01:00
#21: feature/21-add-package-params

Concider moving the duplicated code into its own function e.g. param_type, text_value, value = _get_type_specific_values(self.cleaned_data)

sst commented on pull request mhu/shimatta-kenkyusho#32 2025-01-05 16:32:44 +01:00
#21: feature/21-add-package-params

Either I am blind or you forgot to commit this file :)

sst commented on pull request mhu/shimatta-kenkyusho#32 2025-01-05 16:32:44 +01:00
#21: feature/21-add-package-params

The standard way in python would be to raise a NotImplementedException - so pylint etc. will know you have to override this method.

sst suggested changes for mhu/shimatta-kenkyusho#32 2025-01-05 16:32:44 +01:00
#21: feature/21-add-package-params
sst commented on pull request mhu/shimatta-kenkyusho#32 2025-01-05 16:32:44 +01:00
#21: feature/21-add-package-params

If performance matters it should be possible to forward select the components and add them to the first query using .prefetch_selected

sst pushed to feature/21-add-package-params at mhu/shimatta-kenkyusho 2025-01-05 16:11:16 +01:00
122ae4a731 Merge branch 'develop' into feature/21-add-package-params
46a94c9688 Merge pull request 'Fix #24: Solve recursion bug when importing templates from a fixture' (#29) from bugfix/24-fix-template-import-recursion-bug into develop
21ac4a8c06 Merge pull request 'Fix #30: Update the django filter package. It was incompatible and bricked the web view of the rest API' (#31) from bugfix/30-fix-broken-api-web-rendering into develop
207b5c3fb5 Fix #30: Update the django filter package. It was incompatible.
3450f7475a Fix #24: Solve recursion bug when importing templates from a fixture
Compare 5 commits »
sst approved mhu/shimatta-kenkyusho#27 2024-11-26 22:04:52 +01:00
issue #23 add docu in readme
sst commented on pull request mhu/shimatta-kenkyusho#27 2024-11-26 22:02:22 +01:00
issue #23 add docu in readme
When started for the first time 
sst opened issue mhu/shimatta-kenkyusho#36 2024-11-26 21:50:51 +01:00
Add method to relocate stocks
sst opened issue mhu/shimatta-kenkyusho#35 2024-11-26 21:46:31 +01:00
Add component type search parameter
sst deleted branch bugfix/24-fix-template-import-recursion-bug from mhu/shimatta-kenkyusho 2024-11-24 21:25:33 +01:00
sst pushed to develop at mhu/shimatta-kenkyusho 2024-11-24 21:25:33 +01:00
46a94c9688 Merge pull request 'Fix #24: Solve recursion bug when importing templates from a fixture' (#29) from bugfix/24-fix-template-import-recursion-bug into develop
3450f7475a Fix #24: Solve recursion bug when importing templates from a fixture
Compare 2 commits »
sst merged pull request mhu/shimatta-kenkyusho#29 2024-11-24 21:25:31 +01:00
Fix #24: Solve recursion bug when importing templates from a fixture
sst commented on pull request mhu/shimatta-kenkyusho#29 2024-11-24 21:25:27 +01:00
Fix #24: Solve recursion bug when importing templates from a fixture

Thanks - I had this planned - the same way as you did :)

sst deleted branch bugfix/30-fix-broken-api-web-rendering from mhu/shimatta-kenkyusho 2024-11-24 21:23:38 +01:00
sst pushed to develop at mhu/shimatta-kenkyusho 2024-11-24 21:23:38 +01:00
21ac4a8c06 Merge pull request 'Fix #30: Update the django filter package. It was incompatible and bricked the web view of the rest API' (#31) from bugfix/30-fix-broken-api-web-rendering into develop
207b5c3fb5 Fix #30: Update the django filter package. It was incompatible.
Compare 2 commits »
sst merged pull request mhu/shimatta-kenkyusho#31 2024-11-24 21:23:35 +01:00
Fix #30: Update the django filter package. It was incompatible and bricked the web view of the rest API
sst opened issue mhu/shimatta-kenkyusho#26 2024-11-21 00:23:15 +01:00
Enhance storage/stock display
sst opened issue mhu/shimatta-kenkyusho#25 2024-11-21 00:21:38 +01:00
Allow edit of stock content
sst opened issue mhu/shimatta-kenkyusho#24 2024-11-21 00:15:12 +01:00
Templating breaks data import