3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-12-23 11:43:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Don't use shared_ptr to store test run info in CumulativeReporterBase

Browse Source 
Part of #2089
This commit is contained in:
Martin Hořeňovský 2020-11-11 20:59:28 +01:00
parent 0fa133a0c5
commit 4f14922aa3
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/catch2/reporters/catch_reporter_cumulative_base.cpp
View File

@ -105,9 +105,9 @@ namespace Catch {
} }
void CumulativeReporterBase::testRunEnded( TestRunStats const& testRunStats ) { void CumulativeReporterBase::testRunEnded( TestRunStats const& testRunStats ) {
auto node = std::make_shared<TestRunNode>( testRunStats ); auto node = Detail::make_unique<TestRunNode>( testRunStats );
node->children.swap( m_testGroups ); node->children.swap( m_testGroups );
m_testRuns.push_back( node ); m_testRuns.push_back( std::move(node) );
testRunEndedCumulative(); testRunEndedCumulative();
} }

3
src/catch2/reporters/catch_reporter_cumulative_base.hpp
View File

@ -9,6 +9,7 @@
#define CATCH_REPORTER_CUMULATIVE_BASE_HPP_INCLUDED #define CATCH_REPORTER_CUMULATIVE_BASE_HPP_INCLUDED
#include <catch2/interfaces/catch_interfaces_reporter.hpp> #include <catch2/interfaces/catch_interfaces_reporter.hpp>
#include <catch2/internal/catch_unique_ptr.hpp>
#include <iosfwd> #include <iosfwd>
#include <memory> #include <memory>
@ -77,7 +78,7 @@ namespace Catch {
std::vector<std::shared_ptr<TestCaseNode>> m_testCases; std::vector<std::shared_ptr<TestCaseNode>> m_testCases;
std::vector<std::shared_ptr<TestGroupNode>> m_testGroups; std::vector<std::shared_ptr<TestGroupNode>> m_testGroups;
std::vector<std::shared_ptr<TestRunNode>> m_testRuns; std::vector<Detail::unique_ptr<TestRunNode>> m_testRuns;
std::shared_ptr<SectionNode> m_rootSection; std::shared_ptr<SectionNode> m_rootSection;
std::shared_ptr<SectionNode> m_deepestSection; std::shared_ptr<SectionNode> m_deepestSection;