3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 21:36:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove redundant move to avoid Wredundant-move with Clang

Browse Source 
Signed-off-by: Khem Raj <raj.khem@gmail.com>
This commit is contained in:
Khem Raj 2018-12-17 17:27:43 -08:00 committed by Martin Hořeňovský
parent 9bc15939a5
commit 799c7a2eed
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
include/internal/catch_session.cpp
View File

@ -42,14 +42,19 @@ namespace Catch {
return createReporter(config->getReporterName(), config); return createReporter(config->getReporterName(), config);
} }
auto multi = std::unique_ptr<ListeningReporter>(new ListeningReporter); // On older platforms, returning std::unique_ptr<ListeningReporter>
// when the return type is std::unique_ptr<IStreamingReporter>
// doesn't compile without a std::move call. However, this causes
// a warning on newer platforms. Thus, we have to work around
// it a bit and downcast the pointer manually.
auto ret = std::unique_ptr<IStreamingReporter>(new ListeningReporter);
auto& multi = static_cast<ListeningReporter&>(*ret);
auto const& listeners = Catch::getRegistryHub().getReporterRegistry().getListeners(); auto const& listeners = Catch::getRegistryHub().getReporterRegistry().getListeners();
for (auto const& listener : listeners) { for (auto const& listener : listeners) {
multi->addListener(listener->create(Catch::ReporterConfig(config))); multi.addListener(listener->create(Catch::ReporterConfig(config)));
} }
multi->addReporter(createReporter(config->getReporterName(), config)); multi.addReporter(createReporter(config->getReporterName(), config));
return std::move(multi); return ret;
} }