3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2024-11-22 13:26:10 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused member from Totals

Browse Source 
At one point it was inserted there as the simplest way to smuggle
around an extra return value for specific errors in executing
tests. Since then, the error has been changed to be handled
differently, and the member became unused.
This commit is contained in:
Martin Hořeňovský 2022-01-07 10:34:15 +01:00
parent 39d3de17f3
commit 875299cff0
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/catch2/catch_session.cpp
View File

@ -330,7 +330,7 @@ namespace Catch {
// Note that on unices only the lower 8 bits are usually used, clamping // Note that on unices only the lower 8 bits are usually used, clamping
// the return value to 255 prevents false negative when some multiple // the return value to 255 prevents false negative when some multiple
// of 256 tests has failed // of 256 tests has failed
return (std::min) (MaxExitCode, (std::max) (totals.error, static_cast<int>(totals.assertions.failed))); return (std::min) (MaxExitCode, static_cast<int>(totals.assertions.failed));
} }
#if !defined(CATCH_CONFIG_DISABLE_EXCEPTIONS) #if !defined(CATCH_CONFIG_DISABLE_EXCEPTIONS)
catch( std::exception& ex ) { catch( std::exception& ex ) {

1
src/catch2/catch_totals.hpp
View File

@ -33,7 +33,6 @@ namespace Catch {
Totals delta( Totals const& prevTotals ) const; Totals delta( Totals const& prevTotals ) const;
int error = 0;
Counts assertions; Counts assertions;
Counts testCases; Counts testCases;
}; };