Remove empty implementations of assertionStarting from reporters

src/catch2/reporters/catch_reporter_console.cpp

@@ -416,8 +416,6 @@ void ConsoleReporter::reportInvalidTestSpec( StringRef arg ) {
     m_stream << "Invalid Filter: " << arg << '\n';
 }
 
-void ConsoleReporter::assertionStarting(AssertionInfo const&) {}
-
 void ConsoleReporter::assertionEnded(AssertionStats const& _assertionStats) {
     AssertionResult const& result = _assertionStats.assertionResult;
 

src/catch2/reporters/catch_reporter_console.hpp

@@ -26,8 +26,6 @@ namespace Catch {
         void noMatchingTestCases( StringRef unmatchedSpec ) override;
         void reportInvalidTestSpec( StringRef arg ) override;
 
-        void assertionStarting(AssertionInfo const&) override;
-
         void assertionEnded(AssertionStats const& _assertionStats) override;
 
         void sectionStarting(SectionInfo const& _sectionInfo) override;

src/catch2/reporters/catch_reporter_json.cpp

@@ -280,7 +280,6 @@ namespace Catch {
         endObject();
     }
 
-    void JsonReporter::assertionStarting( AssertionInfo const& /*assertionInfo*/ ) {}
     void JsonReporter::assertionEnded( AssertionStats const& assertionStats ) {
         // TODO: There is lot of different things to handle here, but
         //       we can fill it in later, after we show that the basic

src/catch2/reporters/catch_reporter_json.hpp

@@ -39,7 +39,6 @@ namespace Catch {
         void sectionStarting( SectionInfo const& sectionInfo ) override;
         void sectionEnded( SectionStats const& sectionStats ) override;
 
-        void assertionStarting( AssertionInfo const& assertionInfo ) override;
         void assertionEnded( AssertionStats const& assertionStats ) override;
 
         //void testRunEndedCumulative() override;

src/catch2/reporters/catch_reporter_xml.cpp

@@ -86,8 +86,6 @@ namespace Catch {
         }
     }
 
-    void XmlReporter::assertionStarting( AssertionInfo const& ) { }
-
     void XmlReporter::assertionEnded( AssertionStats const& assertionStats ) {
 
         AssertionResult const& result = assertionStats.assertionResult;

src/catch2/reporters/catch_reporter_xml.hpp

@@ -35,8 +35,6 @@ namespace Catch {
 
         void sectionStarting(SectionInfo const& sectionInfo) override;
 
-        void assertionStarting(AssertionInfo const&) override;
-
         void assertionEnded(AssertionStats const& assertionStats) override;
 
         void sectionEnded(SectionStats const& sectionStats) override;