3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-10-31 20:27:11 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove empty implementations of assertionStarting from reporters

Browse Source
This commit is contained in:
Martin Hořeňovský
2025-07-17 12:47:46 +02:00
parent 0e8112a762
commit ae33e5b99a
6 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/catch2/reporters/catch_reporter_console.cpp
View File

@@ -416,8 +416,6 @@ void ConsoleReporter::reportInvalidTestSpec( StringRef arg ) {
m_stream << "Invalid Filter: " << arg << '\n'; m_stream << "Invalid Filter: " << arg << '\n';
} }
void ConsoleReporter::assertionStarting(AssertionInfo const&) {}
void ConsoleReporter::assertionEnded(AssertionStats const& _assertionStats) { void ConsoleReporter::assertionEnded(AssertionStats const& _assertionStats) {
AssertionResult const& result = _assertionStats.assertionResult; AssertionResult const& result = _assertionStats.assertionResult;

2
src/catch2/reporters/catch_reporter_console.hpp
View File

@@ -26,8 +26,6 @@ namespace Catch {
void noMatchingTestCases( StringRef unmatchedSpec ) override; void noMatchingTestCases( StringRef unmatchedSpec ) override;
void reportInvalidTestSpec( StringRef arg ) override; void reportInvalidTestSpec( StringRef arg ) override;
void assertionStarting(AssertionInfo const&) override;
void assertionEnded(AssertionStats const& _assertionStats) override; void assertionEnded(AssertionStats const& _assertionStats) override;
void sectionStarting(SectionInfo const& _sectionInfo) override; void sectionStarting(SectionInfo const& _sectionInfo) override;

1
src/catch2/reporters/catch_reporter_json.cpp
View File

@@ -280,7 +280,6 @@ namespace Catch {
endObject(); endObject();
} }
void JsonReporter::assertionStarting( AssertionInfo const& /*assertionInfo*/ ) {}
void JsonReporter::assertionEnded( AssertionStats const& assertionStats ) { void JsonReporter::assertionEnded( AssertionStats const& assertionStats ) {
// TODO: There is lot of different things to handle here, but // TODO: There is lot of different things to handle here, but
// we can fill it in later, after we show that the basic // we can fill it in later, after we show that the basic

1
src/catch2/reporters/catch_reporter_json.hpp
View File

@@ -39,7 +39,6 @@ namespace Catch {
void sectionStarting( SectionInfo const& sectionInfo ) override; void sectionStarting( SectionInfo const& sectionInfo ) override;
void sectionEnded( SectionStats const& sectionStats ) override; void sectionEnded( SectionStats const& sectionStats ) override;
void assertionStarting( AssertionInfo const& assertionInfo ) override;
void assertionEnded( AssertionStats const& assertionStats ) override; void assertionEnded( AssertionStats const& assertionStats ) override;
//void testRunEndedCumulative() override; //void testRunEndedCumulative() override;

2
src/catch2/reporters/catch_reporter_xml.cpp
View File

@@ -86,8 +86,6 @@ namespace Catch {
} }
} }
void XmlReporter::assertionStarting( AssertionInfo const& ) { }
void XmlReporter::assertionEnded( AssertionStats const& assertionStats ) { void XmlReporter::assertionEnded( AssertionStats const& assertionStats ) {
AssertionResult const& result = assertionStats.assertionResult; AssertionResult const& result = assertionStats.assertionResult;

2
src/catch2/reporters/catch_reporter_xml.hpp
View File

@@ -35,8 +35,6 @@ namespace Catch {
void sectionStarting(SectionInfo const& sectionInfo) override; void sectionStarting(SectionInfo const& sectionInfo) override;
void assertionStarting(AssertionInfo const&) override;
void assertionEnded(AssertionStats const& assertionStats) override; void assertionEnded(AssertionStats const& assertionStats) override;
void sectionEnded(SectionStats const& sectionStats) override; void sectionEnded(SectionStats const& sectionStats) override;