Static analysis cleanup in tests

This commit is contained in:
Martin Hořeňovský 2023-05-29 21:41:51 +02:00
parent bf5aa7b383
commit dff7513b28
No known key found for this signature in database
GPG Key ID: DE48307B8B0D381A
3 changed files with 5 additions and 5 deletions

View File

@ -95,8 +95,8 @@ namespace {
MoveChecker() = default;
MoveChecker( MoveChecker const& rhs ) = default;
MoveChecker& operator=( MoveChecker const& rhs ) = default;
MoveChecker( MoveChecker&& rhs ) { rhs.has_moved = true; }
MoveChecker& operator=( MoveChecker&& rhs ) {
MoveChecker( MoveChecker&& rhs ) noexcept { rhs.has_moved = true; }
MoveChecker& operator=( MoveChecker&& rhs ) noexcept {
rhs.has_moved = true;
return *this;
}

View File

@ -163,7 +163,7 @@ namespace {
std::vector<std::string>& recorder,
Catch::IConfig const* config ):
EventListenerBase( config ),
m_witness( witness ),
m_witness( CATCH_MOVE(witness) ),
m_recorder( recorder )
{}
@ -181,7 +181,7 @@ namespace {
std::vector<std::string>& recorder,
Catch::ReporterConfig&& config ):
StreamingReporterBase( CATCH_MOVE(config) ),
m_witness( witness ),
m_witness( CATCH_MOVE(witness) ),
m_recorder( recorder )
{}

View File

@ -890,7 +890,7 @@ struct MatcherA : Catch::Matchers::MatcherGenericBase {
return "equals: (int) 1 or (string) \"1\"";
}
bool match( int i ) const { return i == 1; }
bool match( std::string s ) const { return s == "1"; }
bool match( std::string const& s ) const { return s == "1"; }
};
struct MatcherB : Catch::Matchers::MatcherGenericBase {