3rd-party/catch2
1
0
Fork 0
mirror of https://github.com/catchorg/Catch2.git synced 2025-11-03 21:49:32 +01:00
Code Issues Packages Projects Releases Wiki Activity

Static analysis cleanup in tests

Browse Source
This commit is contained in:
Martin Hořeňovský
2023-05-29 21:41:51 +02:00
parent bf5aa7b383
commit dff7513b28
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/SelfTest/IntrospectiveTests/Details.tests.cpp
View File

@@ -95,8 +95,8 @@ namespace {
MoveChecker() = default; MoveChecker() = default;
MoveChecker( MoveChecker const& rhs ) = default; MoveChecker( MoveChecker const& rhs ) = default;
MoveChecker& operator=( MoveChecker const& rhs ) = default; MoveChecker& operator=( MoveChecker const& rhs ) = default;
MoveChecker( MoveChecker&& rhs ) { rhs.has_moved = true; } MoveChecker( MoveChecker&& rhs ) noexcept { rhs.has_moved = true; }
MoveChecker& operator=( MoveChecker&& rhs ) { MoveChecker& operator=( MoveChecker&& rhs ) noexcept {
rhs.has_moved = true; rhs.has_moved = true;
return *this; return *this;
} }

4
tests/SelfTest/IntrospectiveTests/Reporters.tests.cpp
View File

@@ -163,7 +163,7 @@ namespace {
std::vector<std::string>& recorder, std::vector<std::string>& recorder,
Catch::IConfig const* config ): Catch::IConfig const* config ):
EventListenerBase( config ), EventListenerBase( config ),
m_witness( witness ), m_witness( CATCH_MOVE(witness) ),
m_recorder( recorder ) m_recorder( recorder )
{} {}
@@ -181,7 +181,7 @@ namespace {
std::vector<std::string>& recorder, std::vector<std::string>& recorder,
Catch::ReporterConfig&& config ): Catch::ReporterConfig&& config ):
StreamingReporterBase( CATCH_MOVE(config) ), StreamingReporterBase( CATCH_MOVE(config) ),
m_witness( witness ), m_witness( CATCH_MOVE(witness) ),
m_recorder( recorder ) m_recorder( recorder )
{} {}

2
tests/SelfTest/UsageTests/Matchers.tests.cpp
View File

@@ -890,7 +890,7 @@ struct MatcherA : Catch::Matchers::MatcherGenericBase {
return "equals: (int) 1 or (string) \"1\""; return "equals: (int) 1 or (string) \"1\"";
} }
bool match( int i ) const { return i == 1; } bool match( int i ) const { return i == 1; }
bool match( std::string s ) const { return s == "1"; } bool match( std::string const& s ) const { return s == "1"; }
}; };
struct MatcherB : Catch::Matchers::MatcherGenericBase { struct MatcherB : Catch::Matchers::MatcherGenericBase {